Remove redundant iteration in EntitySelectionTree merging algorithm #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
This was referenced Mar 22, 2024
calvincestari
approved these changes
Mar 22, 2024
calvincestari
approved these changes
Mar 22, 2024
calvincestari
deleted the
Remove_redundant_iteration_in_EntitySelectionTree_merging_algorithm
branch
BobaFetters
pushed a commit
that referenced
this pull request
Mar 22, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Mar 22, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Mar 22, 2024
02ac68ac Remove redundant iteration in EntitySelectionTree merging algorithm (#308) git-subtree-dir: apollo-ios-codegen git-subtree-split: 02ac68ac01a88082b69d307a18274b28431fe9c5
BobaFetters
pushed a commit
that referenced
this pull request
Mar 22, 2024
…ntitySelectionTree merging algorithm git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 547a4f0 git-subtree-split: 02ac68ac01a88082b69d307a18274b28431fe9c5
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR refactors the
EntitySelectionTreeinapollo-ios-codegen.What changed?
The conditions for merging selections were revisited. The use of
scopeConditionswas removed from the part of the code where the node's scope is checked if it is deferred. Instead, the condition to add merged inline fragments was moved under the child case, specifically when the child case is selections.How to test?
Unit tests pass
Why make this change?
This is a significant performance improvement as it removes an entire additional iteration through all the conditional scopes in the tree.